[6.0] Import Bionic module from new Android overlay #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
approved these changes
Jul 5, 2024
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci test |
|
Hold off on this, I may want to change the underlying import to |
finagolfin
changed the title
|
Alright, changed the import, can squash the two commits if wanted. @bnbarham, this is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Now that this new overlay was merged into the 6.0 compiler too in swiftlang/swift#74758, this adds the Bionic module from the overlay to the one file that currently adds
import Glibc.Scope: Add import on Android only
Issue: None
Original PR: #211 and #213
Risk: None
Testing: Passed all CI on trunk, plus on my daily Android CI, finagolfin/swift-android-sdk#151
Reviewer: @ahoppen
@bnbarham, easy review.